[pecky]

Hi guys im having some troubles trying to pass on arguments through a construct...

Catchable fatal error: Argument 1 passed to Includer::__construct() must be an instance of string, string given, called in C:\wamp\www\imitizer\includes\classes\settings.php on line 27 and defined in C:\wamp\www\imitizer\includes\classes\includer.php on line 3

erm... "must be an instance of string, string given,"

---

Here is the code; I'm still partially new to constructs, and I need to pass on a parameter through it...

settings.php

		function includer(){
			$includer = new Includer("index.php");
			
			echo $includer;
		}

includer.php

class Includer {
	function __construct(string $p){
		return $p;
	}
}

I have tried experimenting with the string type - without it i get a fancy error saying it couldn't be converted.

Catchable fatal error: Object of class Includer could not be converted to string in C:\wamp\www\imitizer\includes\classes\settings.php on line 29

Thanks

[Nathan]

PHP isn't Java or C, it's not strictly typed. You don't need to specify that you're passing a string as a parameter.

class Includer {
        function __construct($p){
                return $p;
        }
}

However, PHP 5.2 can't convert objects to strings. You'll need a __toString function in the class to echo the $include object.

[pecky]

Ahh thanks

But now though one thing...

In my included files I have two variables, one for the content and one for the title. I need to store this as an array so i can retrieve them and print them out later on the index.

class Includer {
	public $page;
	public $arr;
	function __construct($page){
		$this->page = $page . ".php";
		
		$include = @include_once("includes/".$this->page);
		
		if($include){
			$this->arr = Array("title" => $title,
						 	"content" => $content);
		}
		else{
			$this->arr = Array("title" => "Error",
						 	"content" => "404, page not found!");
		}
	}
	
	public function __toString()
	{
		return $this->arr['content'];
	}
}

I can change arr['content'] and arr['title'] respectively, but I can't return the full array

[Nathan]

Your array is public, you don't need to return it.

echo $includer->arr['content'];

Also, I hope you're sanitizing $page before you pass it to the constructor. It would be better to clean it in the constructor really.

$page doesn't need to be declared either, unless you're using it outside the constructor.

[pecky]

Ahh it's seems like common sense now lol

What do you mean by sanitizing?

[Nathan]

Making sure that only allowed files can be included. Big security risk otherwise.

[pecky]

Ah ye of course

Thanks for the help